From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param Date: Wed, 01 Mar 2017 21:44:29 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1050.oracle.com ([141.146.126.70]:17659 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbdCBCro (ORCPT ); Wed, 1 Mar 2017 21:47:44 -0500 In-Reply-To: (MichalX Potomski's message of "Thu, 23 Feb 2017 09:05:30 +0000") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Potomski, MichalX" Cc: "'vinholikatti@gmail.com'" , "'subhashj@codeaurora.org'" , "'jejb@linux.vnet.ibm.com'" , "'martin.petersen@oracle.com'" , "'linux-scsi@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" , "Janca, Grzegorz" , "Mielczarek, SzymonX" >>>>> "Michal'" == Potomski, MichalX writes: Michal'> Since in UFS 2.1 specification some of the descriptor lengths Michal'> differs from 2.0 specification and some devices, which are Michal'> reporting spec version 2.0 have different descriptor lengths we Michal'> can not rely on hardcoded values taken from 2.0 Michal'> specification. This patch introduces reading these lengths per Michal'> each device from descriptor headers at probe time to ensure Michal'> their correctness. Applied to 4.11/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbdCBFkf (ORCPT ); Thu, 2 Mar 2017 00:40:35 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:27259 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbdCBFke (ORCPT ); Thu, 2 Mar 2017 00:40:34 -0500 To: "Potomski\, MichalX" Cc: "'vinholikatti\@gmail.com'" , "'subhashj\@codeaurora.org'" , "'jejb\@linux.vnet.ibm.com'" , "'martin.petersen\@oracle.com'" , "'linux-scsi\@vger.kernel.org'" , "'linux-kernel\@vger.kernel.org'" , "Janca\, Grzegorz" , "Mielczarek\, SzymonX" Subject: Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param From: "Martin K. Petersen" Organization: Oracle Corporation References: Date: Wed, 01 Mar 2017 21:44:29 -0500 In-Reply-To: (MichalX Potomski's message of "Thu, 23 Feb 2017 09:05:30 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Michal'" == Potomski, MichalX writes: Michal'> Since in UFS 2.1 specification some of the descriptor lengths Michal'> differs from 2.0 specification and some devices, which are Michal'> reporting spec version 2.0 have different descriptor lengths we Michal'> can not rely on hardcoded values taken from 2.0 Michal'> specification. This patch introduces reading these lengths per Michal'> each device from descriptor headers at probe time to ensure Michal'> their correctness. Applied to 4.11/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering