From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: <khalid@gonehiking.org>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <colin.king@canonical.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry()
Date: Fri, 24 Apr 2020 13:30:54 -0400 [thread overview]
Message-ID: <yq1v9lodc4x.fsf@oracle.com> (raw)
In-Reply-To: <20200421034120.28433-1-yanaijie@huawei.com> (Jason Yan's message of "Tue, 21 Apr 2020 11:41:20 +0800")
Jason,
> The '!=' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
> needed here
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-04-24 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 3:41 [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry() Jason Yan
2020-04-22 17:34 ` Khalid Aziz
2020-04-24 17:30 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v9lodc4x.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.