From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6779CA9EA9 for ; Fri, 18 Oct 2019 21:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 857C020679 for ; Fri, 18 Oct 2019 21:26:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="B+/Rjeg5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440490AbfJRV0n (ORCPT ); Fri, 18 Oct 2019 17:26:43 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:54900 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbfJRV0n (ORCPT ); Fri, 18 Oct 2019 17:26:43 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9IL904Q057021; Fri, 18 Oct 2019 21:26:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=Rdq3ONX/dX87B4AGLVLoPA6DFqjOJjr7e716yVVtiqk=; b=B+/Rjeg5QaxTz287c64hPSmmj1NWiw5KmLMzkSz0udwxNCIRvxOXAOsJKVN0RxKCzSLY oNdLd0LJ+y1ZOrIwAZCH88zh8cNNjL4JuoPu7itX8ckMHp36VjUyn+lOQpSali5p5JfI hu0by9nwDxzBUt0iVCaqAN79BJxH4GHCeElHMYC1hcIrHAn8VKHLPhLg4ixNKrPg/QHG tACBqdEF+e2Le4OyZP9F+cSGfe/i6YzdsyztD+Ypa+89ndaFU4Kj5QK8mz5dZzazg550 ASJV/GhJTMi+Zimal21ifN6DwTcJpH1lgB+jOzbbpqbvgnuJhkslWgF1khpTonE6ejEq jA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2vq0q4660j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 21:26:30 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9ILDhQZ179853; Fri, 18 Oct 2019 21:26:30 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2vq0dyhtwp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 21:26:30 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9ILQT49029561; Fri, 18 Oct 2019 21:26:29 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 18 Oct 2019 21:26:29 +0000 To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , Himanshu Madhani , James Bottomley , linux-scsi@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH] qla2xxx: fixup incorrect usage of host_byte From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191018140458.108278-1-hare@suse.de> Date: Fri, 18 Oct 2019 17:26:27 -0400 In-Reply-To: <20191018140458.108278-1-hare@suse.de> (Hannes Reinecke's message of "Fri, 18 Oct 2019 16:04:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9414 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=959 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180187 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9414 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180187 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hannes, > DRIVER_ERROR is a a driver byte setting, not a host byte. The qla2xxx > driver should rather return DID_ERROR here to be in line with the > other drivers. Applied to 5.4/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering