From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Hannes Reinecke <hare@suse.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: aic79xx: fix potential null pointer dereference on ahd
Date: Wed, 06 Jun 2018 01:38:37 +0000 [thread overview]
Message-ID: <yq1vaawelsy.fsf@oracle.com> (raw)
In-Reply-To: <20180531123117.32118-1-colin.king@canonical.com> (Colin King's message of "Thu, 31 May 2018 13:31:17 +0100")
Colin,
> If AHD_DEBUG is enabled and ahd_platform_alloc fails then ahd is set
> to null and the debug printk dereferences ahd when passing it to
> ahd_name. Fix this by moving the debug printk to before the call to
> ahd_platform_alloc where ahd is not null at that point.
Applied to 4.18/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Hannes Reinecke <hare@suse.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: aic79xx: fix potential null pointer dereference on ahd
Date: Tue, 05 Jun 2018 21:38:37 -0400 [thread overview]
Message-ID: <yq1vaawelsy.fsf@oracle.com> (raw)
In-Reply-To: <20180531123117.32118-1-colin.king@canonical.com> (Colin King's message of "Thu, 31 May 2018 13:31:17 +0100")
Colin,
> If AHD_DEBUG is enabled and ahd_platform_alloc fails then ahd is set
> to null and the debug printk dereferences ahd when passing it to
> ahd_name. Fix this by moving the debug printk to before the call to
> ahd_platform_alloc where ahd is not null at that point.
Applied to 4.18/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-06-06 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 12:31 [PATCH] scsi: aic7xxx: aic79xx: fix potential null pointer dereference on ahd Colin King
2018-05-31 12:31 ` Colin King
2018-06-06 1:38 ` Martin K. Petersen [this message]
2018-06-06 1:38 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vaawelsy.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.