From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ilya Dryomov <idryomov@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>, Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: cope with WRITE SAME failing in blkdev_issue_zeroout()
Date: Thu, 21 Sep 2017 00:42:58 -0400 [thread overview]
Message-ID: <yq1vakck6gd.fsf@oracle.com> (raw)
In-Reply-To: <20170919203258.GB7347@lst.de> (Christoph Hellwig's message of "Tue, 19 Sep 2017 22:32:58 +0200")
Christoph,
> I'm really not sure we should check for -EREMOTEIO specifically, but
> Martin who is more familiar with the SCSI code might be able to
> correct me, I'd feel safer about checking for any error which is
> what the old code did.
>
> Except for that the patch looks fine to me.
We explicitly return -EREMOTEIO when the device reports ILLEGAL
REQUEST. But I agree that we should fall back to manually zeroing for
any error.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-09-21 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 17:38 [PATCH] block: cope with WRITE SAME failing in blkdev_issue_zeroout() Ilya Dryomov
2017-09-13 9:50 ` Ilya Dryomov
2017-09-19 9:44 ` Ilya Dryomov
2017-09-19 20:32 ` Christoph Hellwig
2017-09-20 13:03 ` Ilya Dryomov
2017-09-21 4:42 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vakck6gd.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@fb.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.