From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Varun Prakash <varun@chelsio.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
indranil@chelsio.com
Subject: Re: [PATCH] scsi: libcxgbi: fix skb use after free
Date: Tue, 23 May 2017 22:39:36 -0400 [thread overview]
Message-ID: <yq1vaorugev.fsf@oracle.com> (raw)
In-Reply-To: <1494942824-2252-1-git-send-email-varun@chelsio.com> (Varun Prakash's message of "Tue, 16 May 2017 19:23:44 +0530")
Varun,
> skb->data is assigned to task->hdr in cxgbi_conn_alloc_pdu(),
> skb gets freed after tx but task->hdr is still dereferenced in
> iscsi_tcp_task_xmit() to avoid this call skb_get() after allocating
> skb and free the skb in cxgbi_cleanup_task() or before allocating new
> skb in cxgbi_conn_alloc_pdu().
Applied to 4.12/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-24 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 13:53 [PATCH] scsi: libcxgbi: fix skb use after free Varun Prakash
2017-05-19 1:36 ` Martin K. Petersen
2017-05-24 2:39 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vaorugev.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=indranil@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.