From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Stefan Priebe - Profihost AG <s.priebe@profihost.ag>,
NeilBrown <neilb@suse.de>,
linux-raid@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
JBottomley@parallels.com, Jens Axboe <axboe@kernel.dk>,
konrad.wilk@oracle.com, elder@linaro.org,
Josh Durgin <josh.durgin@inktank.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)
Date: Mon, 23 Jun 2014 15:37:03 -0400 [thread overview]
Message-ID: <yq1vbrrh0yo.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20140620182956.GB24389@soda.linbit> (Lars Ellenberg's message of "Fri, 20 Jun 2014 20:29:56 +0200")
>>>>> "Lars" == Lars Ellenberg <lars.ellenberg@linbit.com> writes:
Lars,
Thanks for fixing this.
I'd still like to see you use the lib call instead like you do for
zeroout. I have some patches in the pipeline for multi-range discard
support and things are going to break for drbd if you manually roll
bios.
Lars> linux upstream DRBD also does blk_queue_max_write_same_sectors(q,
Lars> 0) and blk_queue_max_discard_sectors(q, DRBD_MAX_DISCARD_SECTORS)
Great!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-06-23 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 7:02 sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null) Stefan Priebe - Profihost AG
2014-06-20 3:08 ` Martin K. Petersen
2014-06-20 15:53 ` Lars Ellenberg
2014-06-20 16:49 ` Martin K. Petersen
2014-06-20 18:29 ` Lars Ellenberg
2014-06-21 17:48 ` Stefan Priebe
2014-06-23 13:38 ` Lars Ellenberg
2014-06-23 19:37 ` Martin K. Petersen [this message]
2014-06-24 11:53 ` Lars Ellenberg
2014-06-24 23:11 ` Martin K. Petersen
2014-06-25 10:14 ` Lars Ellenberg
2014-06-26 1:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vbrrh0yo.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh.durgin@inktank.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neilb@suse.de \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.