From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] scsi: aha1740: Use str_enabled_disabled() helper
Date: Wed, 12 Feb 2025 22:31:10 -0500 [thread overview]
Message-ID: <yq1wmduttgw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250209081928.3096-2-thorsten.blum@linux.dev> (Thorsten Blum's message of "Sun, 9 Feb 2025 09:19:28 +0100")
Hi Thorsten!
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
This is a very old driver and I'm not too inclined to make cosmetic
changes to it. I'm also not entirely sold on the idea that the helper
makes things more readable. I know what a ternary does, the helper I
have to go look up.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2025-02-13 3:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 8:19 [RESEND PATCH] scsi: aha1740: Use str_enabled_disabled() helper Thorsten Blum
2025-02-13 3:31 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wmduttgw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.