All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: QLogic-Storage-Upstream@cavium.com,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Manish Rangankar <Manish.Rangankar@cavium.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: fix build regression
Date: Tue, 27 Feb 2018 21:19:32 -0500	[thread overview]
Message-ID: <yq1woyx500b.fsf@oracle.com> (raw)
In-Reply-To: <20180226094422.2607574-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 26 Feb 2018 10:44:14 +0100")


Arnd,

> A bugfix I did caused a build regression in some other randconfig
> builds in a rare combination of options:
>
> In file included from drivers/scsi/qedi/qedi_fw.c:16:
> drivers/scsi/qedi/qedi_gbl.h:26:38: error: array type has incomplete element type 'struct qedi_debugfs_ops'
>  extern const struct qedi_debugfs_ops qedi_debugfs_ops[];
>                                       ^~~~~~~~~~~~~~~~
>
> This removes the useless #ifdef around the declarations in qedi_dbg.h
> to make it always build.

Applied to 4.17/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

      reply	other threads:[~2018-02-28  2:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  9:44 [PATCH] scsi: qedi: fix build regression Arnd Bergmann
2018-02-28  2:19 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1woyx500b.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=Manish.Rangankar@cavium.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=arnd@arndb.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.