From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
qla2xxx-upstream@qlogic.com,
Himanshu Madhani <himanshu.madhani@cavium.com>,
Hannes Reinecke <hare@suse.de>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
Date: Sat, 01 Jul 2017 16:50:19 -0400 [thread overview]
Message-ID: <yq1wp7rx4ok.fsf@oracle.com> (raw)
In-Reply-To: <20170623071011.21184-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Fri, 23 Jun 2017 09:10:11 +0200")
Johannes,
> In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> qpair->qp_lock but do access members of the qpair before having the lock.
> Re-order the locking sequence to have all read and write access to qpair
> members under the qpair->qp_lock.
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-07-01 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 7:10 [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Johannes Thumshirn
2017-06-28 1:32 ` Martin K. Petersen
2017-06-28 1:44 ` Madhani, Himanshu
2017-06-28 16:33 ` Madhani, Himanshu
2017-07-01 20:50 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wp7rx4ok.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=himanshu.madhani@cavium.com \
--cc=john.garry@huawei.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.