From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 01 Dec 2016 00:54:46 +0000 Subject: Re: [patch] scsi: dpt_i2o: double free on error path Message-Id: List-Id: References: <20161130193648.GA24818@mwanda> In-Reply-To: <20161130193648.GA24818@mwanda> (Dan Carpenter's message of "Wed, 30 Nov 2016 22:36:48 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Adaptec OEM Raid Solutions , Quentin Lambert , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org >>>>> "Dan" = Dan Carpenter writes: Dan> We recently introduced a kfree() in the caller for this function. Dan> That's where, logically, you would think the kfree() should be. Dan> Unfortunately the code was just ugly and not buggy so the static Dan> checker warning was a false postive and introduced a double free. Dan> I've removed the old kfree() and left the new one. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [patch] scsi: dpt_i2o: double free on error path Date: Wed, 30 Nov 2016 19:54:46 -0500 Message-ID: References: <20161130193648.GA24818@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:16780 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758124AbcLAAza (ORCPT ); Wed, 30 Nov 2016 19:55:30 -0500 In-Reply-To: <20161130193648.GA24818@mwanda> (Dan Carpenter's message of "Wed, 30 Nov 2016 22:36:48 +0300") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter Cc: Adaptec OEM Raid Solutions , Quentin Lambert , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org >>>>> "Dan" == Dan Carpenter writes: Dan> We recently introduced a kfree() in the caller for this function. Dan> That's where, logically, you would think the kfree() should be. Dan> Unfortunately the code was just ugly and not buggy so the static Dan> checker warning was a false postive and introduced a double free. Dan> I've removed the old kfree() and left the new one. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering