From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI Date: Tue, 29 Nov 2016 11:58:38 -0500 Message-ID: References: <1479947042.10230.88.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:32834 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755947AbcK2Q65 (ORCPT ); Tue, 29 Nov 2016 11:58:57 -0500 In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> (Benjamin Herrenschmidt's message of "Thu, 24 Nov 2016 11:24:02 +1100") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Brian King Cc: Benjamin Herrenschmidt , linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , linuxppc dev list >>>>> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain Benjamin> asserted forever. This is controlled by the "clear_isr" flag. Benjamin> While we set that flag properly when deciding initially Benjamin> whether to use LSIs or MSIs, we fail to set it if we first Benjamin> chose MSIs, the test fails, then fallback to LSIs. Brian: Please review! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tSqWh1tbxzDvrZ for ; Wed, 30 Nov 2016 03:58:55 +1100 (AEDT) To: Brian King Cc: Benjamin Herrenschmidt , linux-scsi@vger.kernel.org, "linux-kernel\@vger.kernel.org" , linuxppc dev list Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI From: "Martin K. Petersen" References: <1479947042.10230.88.camel@kernel.crashing.org> Date: Tue, 29 Nov 2016 11:58:38 -0500 In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> (Benjamin Herrenschmidt's message of "Thu, 24 Nov 2016 11:24:02 +1100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>>>> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain Benjamin> asserted forever. This is controlled by the "clear_isr" flag. Benjamin> While we set that flag properly when deciding initially Benjamin> whether to use LSIs or MSIs, we fail to set it if we first Benjamin> chose MSIs, the test fails, then fallback to LSIs. Brian: Please review! -- Martin K. Petersen Oracle Linux Engineering