From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jack Wang <jinpu.wang@profitbricks.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, elliott@hpe.com
Subject: Re: [PATCH v2] block: ratelimite pr_err on IO path
Date: Thu, 12 Apr 2018 17:20:54 -0400 [thread overview]
Message-ID: <yq1y3hsunnt.fsf@oracle.com> (raw)
In-Reply-To: <1523524915-25170-1-git-send-email-jinpu.wangl@profitbricks.com> (Jack Wang's message of "Thu, 12 Apr 2018 11:21:55 +0200")
Jack,
> + pr_err_ratelimited("%s: ref tag error at location %llu (rcvd %u)\n",
I'm a bit concerned about dropping records of potential data loss.
Also, what are you doing that compels all these to be logged? This
should be a very rare occurrence.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-04-12 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 9:21 [PATCH v2] block: ratelimite pr_err on IO path Jack Wang
2018-04-12 21:20 ` Martin K. Petersen [this message]
2018-04-13 8:37 ` Jinpu Wang
2018-04-13 16:59 ` Martin K. Petersen
2018-04-13 16:59 ` Martin K. Petersen
2018-04-16 8:16 ` Jinpu Wang
2018-04-16 9:06 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3hsunnt.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=elliott@hpe.com \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.