From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] scsi: eata: drop VLA in reorder() From: "Martin K. Petersen" References: <1520802418-17284-1-git-send-email-s.mesoraca16@gmail.com> <20180312030834.GC8631@eros> Date: Mon, 12 Mar 2018 22:35:36 -0400 In-Reply-To: (Linus Torvalds's message of "Mon, 12 Mar 2018 11:45:53 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain To: Linus Torvalds Cc: "Tobin C. Harding" , Arthur Marsh , Salvatore Mesoraca , Linux Kernel Mailing List , Kernel Hardening , Linux SCSI List , "James E.J. Bottomley" , "Martin K. Petersen" , Dario Ballabio , Kees Cook , kernelnewbies@kernelnewbies.org List-ID: Linus, > That said, I wonder if the solution to this particular driver is > "delete it". Because the hardware is truly ancient and nobody sane > would use it any more. I'm not aware of anybody actively using these anymore. They are mid-nineties vintage with an M68K processor onboard. I ran a couple of these when they were new but haven't had a working board in probably a decade. No objections to Salvatore's patch but I have a slight affinity for retiring unused code over patching it. So unless there are objections... -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin.petersen@oracle.com (Martin K. Petersen) Date: Mon, 12 Mar 2018 22:35:36 -0400 Subject: [PATCH] scsi: eata: drop VLA in reorder() In-Reply-To: (Linus Torvalds's message of "Mon, 12 Mar 2018 11:45:53 -0700") References: <1520802418-17284-1-git-send-email-s.mesoraca16@gmail.com> <20180312030834.GC8631@eros> Message-ID: To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org Linus, > That said, I wonder if the solution to this particular driver is > "delete it". Because the hardware is truly ancient and nobody sane > would use it any more. I'm not aware of anybody actively using these anymore. They are mid-nineties vintage with an M68K processor onboard. I ran a couple of these when they were new but haven't had a working board in probably a decade. No objections to Salvatore's patch but I have a slight affinity for retiring unused code over patching it. So unless there are objections... -- Martin K. Petersen Oracle Linux Engineering