From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw
Date: Fri, 08 Feb 2019 18:13:55 -0500 [thread overview]
Message-ID: <yq1zhr5vpos.fsf@oracle.com> (raw)
In-Reply-To: <1549450376-114929-2-git-send-email-john.garry@huawei.com> (John Garry's message of "Wed, 6 Feb 2019 18:52:51 +0800")
John,
Just noticed this while inspecting the resulting complete diff:
> static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
> {
> unsigned char prot_flags = scsi_cmnd->prot_flags;
>
> - if (prot_flags & SCSI_PROT_TRANSFER_PI) {
> - if (prot_flags & SCSI_PROT_REF_CHECK)
> - return 0xc << 16;
> - return 0xfc << 16;
> - }
> - return 0;
> + if (prot_flags & SCSI_PROT_REF_CHECK)
> + return T10_CHK_APP_TAG_MSK;
Polarity is a bit unclear here. Is this statement disabling checking of
the app tag?
> + return T10_CHK_REF_TAG_MSK | T10_CHK_APP_TAG_MSK;
> }
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw
Date: Fri, 08 Feb 2019 18:13:55 -0500 [thread overview]
Message-ID: <yq1zhr5vpos.fsf@oracle.com> (raw)
In-Reply-To: <1549450376-114929-2-git-send-email-john.garry@huawei.com> (John Garry's message of "Wed, 6 Feb 2019 18:52:51 +0800")
John,
Just noticed this while inspecting the resulting complete diff:
> static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
> {
> unsigned char prot_flags = scsi_cmnd->prot_flags;
>
> - if (prot_flags & SCSI_PROT_TRANSFER_PI) {
> - if (prot_flags & SCSI_PROT_REF_CHECK)
> - return 0xc << 16;
> - return 0xfc << 16;
> - }
> - return 0;
> + if (prot_flags & SCSI_PROT_REF_CHECK)
> + return T10_CHK_APP_TAG_MSK;
Polarity is a bit unclear here. Is this statement disabling checking of
the app tag?
> + return T10_CHK_REF_TAG_MSK | T10_CHK_APP_TAG_MSK;
> }
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-02-08 23:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:52 [PATCH 0/6] hisi_sas: DIX support, performance optimisation, and misc patches John Garry
2019-02-06 10:52 ` John Garry
2019-02-06 10:52 ` [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw John Garry
2019-02-06 10:52 ` John Garry
2019-02-08 23:13 ` Martin K. Petersen [this message]
2019-02-08 23:13 ` Martin K. Petersen
2019-02-11 11:36 ` chenxiang (M)
2019-02-11 11:36 ` chenxiang (M)
2019-02-13 3:01 ` Martin K. Petersen
2019-02-13 3:01 ` Martin K. Petersen
2019-02-06 10:52 ` [PATCH 2/6] scsi: hisi_sas: Add manual trigger for debugfs dump John Garry
2019-02-06 10:52 ` John Garry
2019-02-06 10:52 ` [PATCH 3/6] scsi: hisi_sas: change queue depth from 512 to 4096 John Garry
2019-02-06 10:52 ` John Garry
2019-02-06 10:52 ` [PATCH 4/6] scsi: hisi_sas: Issue internal abort on all relevant queues John Garry
2019-02-06 10:52 ` John Garry
2019-02-06 10:52 ` [PATCH 5/6] scsi: hisi_sas: Use pci_irq_get_affinity() for v3 hw as experimental John Garry
2019-02-06 10:52 ` John Garry
2019-02-06 10:52 ` [PATCH 6/6] scsi: hisi_sas: Do some more tidy-up John Garry
2019-02-06 10:52 ` John Garry
2019-02-08 23:08 ` [PATCH 0/6] hisi_sas: DIX support, performance optimisation, and misc patches Martin K. Petersen
2019-02-08 23:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhr5vpos.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.