From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DAD39AD3A; Tue, 21 Jul 2026 14:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784643626; cv=none; b=U6s8E4iksv1XujehotOGvVkS/Ly0xxQ9KQWRxumY8QBMGWxJTkkbia2YatLZoTocZy3DM0aoNh3xq5Kg8Xou5SIt60+cB9zTVKJVd5jof+PMvF9RB5ELSDwsQHmcu/+iBTX4rm3jfAxnkYi8ELWE/R+xzIJPqJgktGjwZW9yxiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784643626; c=relaxed/simple; bh=Q/j682BHn4/bqEtQENQgsu0DCJvAVU5yzDBtUSeFGGY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=B5o/m9FE6eD1mxSOzz1JOEUgJrxrmM/MYvJs66uhrqKJUIXsnmJowOS3ISM9wZKK7cVBk3S0zyHybTnenZ2HRaMV/MSOYiSistuLej29hN1RotF2l7BlJpecAbE+w1/bJdps5+Xwg8bnkgtioTuPJvCIoWIgMCbdifBBQQZN5WQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZAXeJTn5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZAXeJTn5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992DD1F000E9; Tue, 21 Jul 2026 14:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784643624; bh=0vlMnn1H9hiO4jT5wquIo2lbFYyrtK27kHf9bWe+2BM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ZAXeJTn5Gpmsi+fP/8KnFVJrWtLr1s+gLT8XCY+gJDlj/j3JD5/rYU5iAxSrzp+pd olYQzw9d9qnF622vSrO0xgj0l2V/UWVA/TwCEdteCq9j5ZG5/DBjpuMXcH9FrxHWil v85SMWGDxZbPRG2SeJtJpKBw0NI86LxW0iHL6uBUKgcqneXjADoUesd7rroKVKo3mm SC9mFdCU8LmsaoJ7LEzSPJZXaM2HeNcQ54nqu/ic/L5F5VrXdzNVoDsdMC66+nliHc cM0qXX4fadGnq6/2LCkf6IQ7hjwQ818TGBo7IX/dKg+5Y2YA0GOVfKLHel40zJ33wz APR8zrlv8Umyg== X-Mailer: emacs 30.2 (via feedmail 11-beta-1 I) From: Aneesh Kumar K.V To: Leon Romanovsky Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Jason Gunthorpe , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, stable@vger.kernel.org, Michael Kelley , Jason Gunthorpe Subject: Re: [PATCH v8 01/23] dma-direct: return struct page from dma_direct_alloc_from_pool() In-Reply-To: <20260721115456.GI110966@unreal> References: <20260717180442.110954-1-aneesh.kumar@kernel.org> <20260717180442.110954-2-aneesh.kumar@kernel.org> <20260721115456.GI110966@unreal> Date: Tue, 21 Jul 2026 19:50:10 +0530 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Leon Romanovsky writes: > On Fri, Jul 17, 2026 at 11:34:19PM +0530, Aneesh Kumar K.V (Arm) wrote: >> Commit 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool >> helper") changed dma_direct_alloc_from_pool() to return the CPU address >> from dma_alloc_from_pool(). That fits dma_direct_alloc(), but >> dma_direct_alloc_pages() also uses the helper and expects a struct page *. >> >> Fix this by making dma_direct_alloc_from_pool() return the struct page * >> again, and pass the CPU address back through an out-parameter for the >> dma_direct_alloc() caller. >> >> Fixes: 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool helper") >> Cc: stable@vger.kernel.org >> Tested-by: Michael Kelley >> Tested-by: Mostafa Saleh >> Reviewed-by: Jason Gunthorpe >> Signed-off-by: Aneesh Kumar K.V (Arm) >> --- >> kernel/dma/direct.c | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c >> index d8219efe3273..363d984d90e7 100644 >> --- a/kernel/dma/direct.c >> +++ b/kernel/dma/direct.c >> @@ -164,22 +164,21 @@ static bool dma_direct_use_pool(struct device *dev, gfp_t gfp) >> return !gfpflags_allow_blocking(gfp) && !is_swiotlb_for_alloc(dev); >> } >> >> -static void *dma_direct_alloc_from_pool(struct device *dev, size_t size, >> - dma_addr_t *dma_handle, gfp_t gfp) >> +static struct page *dma_direct_alloc_from_pool(struct device *dev, size_t size, >> + dma_addr_t *dma_handle, void **cpu_addr, gfp_t gfp) >> { >> struct page *page; >> u64 phys_limit; >> - void *ret; >> >> if (WARN_ON_ONCE(!IS_ENABLED(CONFIG_DMA_COHERENT_POOL))) >> return NULL; >> >> gfp |= dma_direct_optimal_gfp_mask(dev, &phys_limit); >> - page = dma_alloc_from_pool(dev, size, &ret, gfp, dma_coherent_ok); >> + page = dma_alloc_from_pool(dev, size, cpu_addr, gfp, dma_coherent_ok); >> if (!page) >> return NULL; >> *dma_handle = phys_to_dma_direct(dev, page_to_phys(page)); >> - return ret; >> + return page; >> } >> >> static void *dma_direct_alloc_no_mapping(struct device *dev, size_t size, >> @@ -247,8 +246,11 @@ void *dma_direct_alloc(struct device *dev, size_t size, >> * the atomic pools instead if we aren't allowed block. >> */ >> if ((remap || force_dma_unencrypted(dev)) && >> - dma_direct_use_pool(dev, gfp)) >> - return dma_direct_alloc_from_pool(dev, size, dma_handle, gfp); >> + dma_direct_use_pool(dev, gfp)) { >> + page = dma_direct_alloc_from_pool(dev, size, dma_handle, >> + &ret, gfp); >> + return page ? ret : NULL; > > Sorry for joining the discussion late, but the line above caught my > attention. > > Why do we need both ret and page? We can derive cpu_addr from page and > vice versa. Do we really need the &ret parameter? Or, more generally, do > we really need "struct page *"? > > static struct page *__dma_alloc_from_pool(struct device *dev, size_t size, > struct gen_pool *pool, void **cpu_addr, > bool (*phys_addr_ok)(struct device *, phys_addr_t, size_t)) > { > ... > *cpu_addr = (void *)addr; > memset(*cpu_addr, 0, size); > return pfn_to_page(__phys_to_pfn(phys)); > } > > Why > With CONFIG_DMA_DIRECT_REMAP the cpu_addr can be different from page_address. -aneesh