From: Sven Schnelle <svens@linux.ibm.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, sumanthk@linux.ibm.com, agordeev@linux.ibm.com,
gor@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [PATCH] perf/test: fix perf ftrace test on s390
Date: Fri, 08 Nov 2024 07:28:21 +0100 [thread overview]
Message-ID: <yt9diksyqlx6.fsf@linux.ibm.com> (raw)
In-Reply-To: <Zy0X9kz_tmjNue5D@google.com> (Namhyung Kim's message of "Thu, 7 Nov 2024 11:41:42 -0800")
Namhyung Kim <namhyung@kernel.org> writes:
> On Thu, Nov 07, 2024 at 01:33:43PM +0100, Thomas Richter wrote:
>> On s390 the perf test case ftrace sometimes fails as follows:
>>
>> # ./perf test ftrace
>> 79: perf ftrace tests : FAILED!
>> #
>>
>> The failure depends on the kernel .config file. Some configurarions
>> always work fine, some do not.
>
> Which test do you fail? ftrace trace or profile? I don't think it's
> gonna be a problem for ftrace latency.
The ftrace profile test failed, because the ring buffer was not large
enough, and some lines (especially the interesting ones with nanosleep
in it) where dropped.
>
>> To achieve success for all our tested kernel configurations, enlarge
>> the buffer to store the traces complete without wrapping.
>> The default buffer size is too small for all kernel configurations.
>> Set the buffer size of /sys/kernel/tracing/buffer_size_kb to 16 MB
>
> Actually you can use -m 16M option for perf ftrace trace and perf ftrace
> profile. Then you don't need to care about restoring the original size.
Ok, thanks. I leave it to Thomas to decide whether he wants to add this
option to the CI run.
Thanks!
prev parent reply other threads:[~2024-11-08 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 12:33 [PATCH] perf/test: fix perf ftrace test on s390 Thomas Richter
2024-11-07 19:41 ` Namhyung Kim
2024-11-08 6:28 ` Sven Schnelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9diksyqlx6.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sumanthk@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.