From: Sven Schnelle <svens@linux.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data
Date: Mon, 03 Aug 2020 16:01:18 +0200 [thread overview]
Message-ID: <yt9dr1sn3k29.fsf@linux.ibm.com> (raw)
In-Reply-To: <87ime0lyg6.fsf@nanos.tec.linutronix.de> (Thomas Gleixner's message of "Mon, 03 Aug 2020 14:13:13 +0200")
Thomas Gleixner <tglx@linutronix.de> writes:
> just a few nits.
>
> Can you please spare that #ifdef and do:
>
> #ifdef CONFIG_ARCH_HAS_VDSO_DATA
> #include <asm/vdso/data.h>
> #else
> struct arch_vdso_data {};
> #endif
Ok.
> Please keep the tabular alignment of the struct members and add kernel
> doc in the comment above the struct.
Ok.
> Aside of that 'arch' is not really a intuitive name. 'arch_data' or
> something like that. Hmm?
arch_data is fine, thank you for your comments.
Regards
Sven
next prev parent reply other threads:[~2020-08-03 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 5:56 [PATCH RFC] s390: convert to GENERIC_VDSO Sven Schnelle
2020-08-03 5:56 ` [PATCH 1/2] vdso: allow to add architecture-specific vdso data Sven Schnelle
2020-08-03 12:13 ` Thomas Gleixner
2020-08-03 14:01 ` Sven Schnelle [this message]
2020-08-03 5:56 ` [PATCH 2/2] s390: convert to GENERIC_VDSO Sven Schnelle
2020-08-03 12:29 ` Thomas Gleixner
2020-08-03 12:29 ` Thomas Gleixner
2020-08-03 14:09 ` Sven Schnelle
2020-08-03 16:05 ` Thomas Gleixner
2020-08-03 18:44 ` Heiko Carstens
2020-08-03 19:27 ` Thomas Gleixner
2020-08-03 20:12 ` Heiko Carstens
2020-08-04 9:22 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dr1sn3k29.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.