From: Sven Schnelle <svens@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH 1/2] entry: Rename arch_check_user_regs() to arch_enter_from_user_mode()
Date: Mon, 09 May 2022 08:20:41 +0200 [thread overview]
Message-ID: <yt9dsfpjgrba.fsf@linux.ibm.com> (raw)
In-Reply-To: <YnV3iljKUM0Fqw/F@hirez.programming.kicks-ass.net> (Peter Zijlstra's message of "Fri, 6 May 2022 21:31:22 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> On Wed, May 04, 2022 at 08:23:50AM +0200, Thomas Richter wrote:
>> From: Sven Schnelle <svens@linux.ibm.com>
>>
>> arch_check_user_regs() is used at the moment to verify that struct pt_regs
>> contains valid values when entering the kernel from userspace. s390 needs
>> a place in the generic entry code to modify a cpu data structure when
>> switching from userspace to kernel mode. As arch_check_user_regs() is
>> exactly this, rename it to arch_enter_from_user_mode().
>>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
>> ---
>
> With the note that NMI doesn't (necessarily) call this..
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
How about:
"When entering the kernel from userspace, arch_check_user_regs() is
used to verify that struct pt_regs contains valid values. Note that
the NMI codepath doesn't call this function. s390 needs a place in the
generic entry code to modify a cpu data structure when switching from
userspace to kernel mode. As arch_check_user_regs() is exactly this,
rename it to arch_enter_from_user_mode()."
next prev parent reply other threads:[~2022-05-09 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 6:23 [PATCH 0/2] s390/pai: Add support for Processor Activity Instrumentation Thomas Richter
2022-05-04 6:23 ` [PATCH 1/2] entry: Rename arch_check_user_regs() to arch_enter_from_user_mode() Thomas Richter
2022-05-06 19:31 ` Peter Zijlstra
2022-05-09 6:20 ` Sven Schnelle [this message]
2022-05-09 7:08 ` Peter Zijlstra
2022-05-09 9:55 ` Heiko Carstens
2022-05-06 19:38 ` Thomas Gleixner
2022-05-06 19:49 ` Heiko Carstens
2022-05-06 21:55 ` Thomas Gleixner
2022-05-04 6:23 ` [PATCH 2/2] s390/pai: Add support for cryptography counters Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dsfpjgrba.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.