From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: apply phase pointer override on
	SNB+ too
Date: Fri, 29 Jul 2011 10:28:51 -0700
Message-ID: <yun39hphu7g.fsf@aiko.keithp.com>
References: <1311898032-6625-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1062866101=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id BBB169E8DD
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Jul 2011 10:28:54 -0700 (PDT)
In-Reply-To: <1311898032-6625-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1062866101==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 28 Jul 2011 17:07:12 -0700, Jesse Barnes <jbarnes@virtuousgeek.org>=
 wrote:

> +#define _TRANSA_CHICKEN2	 0xf0064
> +#define _TRANSB_CHICKEN2	 0xf1064
> +#define TRANS_CHICKEN2(pipe) _PIPE(pipe, _TRANSA_CHICKEN2, _TRANSB_CHICK=
EN2)
> +#define   TRANS_AUTOTRAIN_GEN_STALL_DIS	(1<<31)
> +
> +#define SOUTH_CHICKEN1		0xc2000
> +#define  FDIA_PHASE_SYNC_SHIFT	18
> +#define  FDI_PHASE_SYNC_OVR_EN	(3)

How about

#define FDIA_PHASE_SYNC_OVERRIDE_SHIFT  19
#define FDIA_PHASE_SYNC_ENABLE_SHIFT    18
#define FDI_PHASE_SYNC_OVERRIDE(pipe) (1 << (FDIA_PHASE_SYNC_OVERRIDE_SHIFT=
 - (pipe) * 2))
#define FDI_PHASE_SYNC_ENABLE(pipe)   (1 << (FDIA_PHASE_SYNC_ENABLE_SHIFT -=
 (pipe) * 2))

defines instead?

Then use FDI_PHASE_SYNC_OVERRIDE(pipe) | FDI_PHASE_SYNC_ENABLE(pipe)

in the code.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOMu3TQp8BWwlsTdMRAkAQAJ92Ij/Ui7Y2hQ2hxvRzMn76GTJUngCaAyV6
SaharB9z25+D2HZ/noO135M=
=puQi
-----END PGP SIGNATURE-----
--=-=-=--

--===============1062866101==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1062866101==--