From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] Revert "drm/i915: Kill GTT mappings when moving from GTT domain" Date: Tue, 21 Jun 2011 11:09:05 -0700 Message-ID: References: <1308094989-3153-1-git-send-email-eric@anholt.net> <87tybrcet0.fsf@eliezer.anholt.net> <87mxhg5lbl.fsf@eliezer.anholt.net> <87liwyao3u.fsf@eliezer.anholt.net> <013811$h7gjb@fmsmga002.fm.intel.com> <87y60xpxgc.fsf@eliezer.anholt.net> <87zkld8qnl.fsf@eliezer.anholt.net> <013811$h8tfb@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1303883943==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 3466A9E774 for ; Tue, 21 Jun 2011 11:09:09 -0700 (PDT) In-Reply-To: <013811$h8tfb@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1303883943== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 19 Jun 2011 22:49:36 +0100, Chris Wilson = wrote: > The patch closes a race condition. The essence of your complaint is that > the kernel is not as fast as we need it to be, and that the initial upload > to any object is slower than expected. I presume you also have a plan for > fixing the underwhelming performance of a glibc memcpy through an > established GTT mapping? I see a performance regression in a critical path for most applications (texture upload), and I'm not seeing any bug report that your fix closes. That seems pretty conclusive to me; I'll plan on pushing a revert of this patch to eliminate the regression from the previous version. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOAN5BQp8BWwlsTdMRAnByAKCE9YEAU3uZW5BKfEKzKft6DFX9/gCgv11x pHGJMiTuLDAkW1tWd+AfWV0= =/Y/1 -----END PGP SIGNATURE----- --=-=-=-- --===============1303883943== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1303883943==--