From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/2] drm/i915: properly prefault for pread/pwrite Date: Sun, 23 Oct 2011 12:23:47 -0700 Message-ID: References: <1317203844-2930-1-git-send-email-daniel.vetter@ffwll.ch> <1317203844-2930-2-git-send-email-daniel.vetter@ffwll.ch> <20111023101830.GE2953@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1706925500==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id DE9EF9E78F for ; Sun, 23 Oct 2011 12:23:50 -0700 (PDT) In-Reply-To: <20111023101830.GE2953@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Chris Wilson Cc: Daniel Vetter , intel-gfx , stable@kernel.org List-Id: intel-gfx@lists.freedesktop.org --===============1706925500== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 23 Oct 2011 12:18:30 +0200, Daniel Vetter wrote: > Hi Keith, >=20 > This patch isn't in your -next pull. This papers over a spurious -EFAULT > in the pwrite/pread paths that actually gets hit in the wild. The real fix > in the form of a almost complete rewrite of the pwrite/pread paths won't > be ready for 3.2. We had several comments wondering whether writing zeros was OK as this occurs before some potential error returns that should leave the buffer unmodified. I didn't have a better suggestion, but that seems pretty sketchy to me. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTqRpwzYtFsjWk68qAQgDpg//YI1I5Q4V7ctwjDh45MrK9XlTl2G2Uo6k 3fZJjLDuyqwtxR14ObEoub6WQGIwQRbCOH7gb4pCSTA4/zkfEkvcRe32kMrmNv+r IzD2/hn/T9uv/G3fXWbQ3YpYKBYdUh5KYtn4pdu3293U1ztUK1NnBmQRHdHShd3P bUIiLbdVEmaT4iSn5zeyGSL5PMaIn0GC4haKVX+wypmKdV5/o3ksM7kvCYFEwfGl BK4uDZatKPPOxSLsncggH6eNXh23Rkki+f9KMUbM/o2SRukioolqJa9B++H7w/uz 9S4YtJdHTlOfx/yJOoNSM0KA1DjKHh0xnVA3x8c6h8roRs0JoF6e3X8AhTNXV7iM qg6NDt/WVvk7ZwtBxvAFR/U1caMZvdXGMQWi0ry28Rie1XK8xtOBKA7OPPpEJ+NH 2sJZ9gcqifQc5idioHqQV0UiMbIOEe7jshU0hOFiUnkU+CGgFwAX3OGueJTs+J6T apI/TSq5tUte8P3FWoEqdawQM+4pnc9lKjlkenXEyj9EErkbO/UJiD+I95kbfnND tTgOMD07AFLI2B1iZ4IIco5alvHiw+ObAyjeX+pSn7OTNTF8eh4eGbEQkKCwUPVq lfCiT6WHTsHLR1Al2w6pSdgoLCmxwe6x4NuhRDYHk0CoiHdo9PFmZM9+/M+hRjjD JTurSmeUX5w= =7Nab -----END PGP SIGNATURE----- --=-=-=-- --===============1706925500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1706925500==--