From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: FBC fixes for review and testing Date: Thu, 07 Jul 2011 08:45:37 -0700 Message-ID: References: <1310039291-22554-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1862646896==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FAB39E768 for ; Thu, 7 Jul 2011 09:04:21 -0700 (PDT) In-Reply-To: <1310039291-22554-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1862646896== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 7 Jul 2011 12:48:05 +0100, Chris Wilson = wrote: > FBC is currently disabled upstream due a few conflicting requirements > and questionable benefit. It is also buggy... >=20 > https://bugs.freedesktop.org/show_bug.cgi?id=3D33487 is the current open > SNB bug where FBC prevents the screen from being redrawn under a > compositing WM. At last it appears that we have found the cause and a > solution, so please do give these patches some testing - you will need > to pass i915.i915_enable_fbc=3D1 to override the forced disabling of > FBC. This all looks good to me. I've one question though -- enable_fbc needs to wait for vblank only to make sure it is disabled before turning it back on right? If so, it seems like we could simply disable FBC immediately, and then schedule the enable at the next vblank interval (or even several vblank intervals in the future). Seems like this would effectively eliminate waiting with the struct_mutex held, which seems like a nice feature to me. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOFdShQp8BWwlsTdMRAuU8AKDLIqY/JIecwnvjq5Sw+O+q0IStqgCg5zYq whUPBCC44yO2w0F6gfzb/0A= =Iz27 -----END PGP SIGNATURE----- --=-=-=-- --===============1862646896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1862646896==--