From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required Date: Fri, 14 Oct 2011 23:11:52 -0700 Message-ID: References: <1318610630-20459-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0776097413==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C9999E8A0 for ; Fri, 14 Oct 2011 23:11:59 -0700 (PDT) In-Reply-To: <1318610630-20459-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0776097413== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 14 Oct 2011 12:43:49 -0400, Adam Jackson wrote: > The previous code was confused about units, which is pretty reasonable > given that the units themselves are confusing. Thanks for actually figuring this out; the comment before that function should have indicated to any reader that I couldn't figure out what that computation should have been. One question -- do you have an example of where the old computation failed and the new one works? =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTpkkKDYtFsjWk68qAQje/Q//cVqGhIT20eLSrCryKZgiNfaH7ZNEureI cvURzImZ1hn7t0DVo9MFhzGh1KKP89BHJs9lMAvTEcAHOx2LNuy/G1tX0X94+m57 THfDbymYUAHWYxpJcfdU2e+kMoc/HX73yNxBTAEpMlDqIJBnCinq5RraIDCJmE3E VOi2B0WqDAxNDPRN5la8Gt3C46sWHaiNlvMOzprmu3TdLNz2a8WJUznaFX2EqEz9 pha8Wbxo4gf2QYILHAwh7PZbmW/pewWQM7Lt8uXXDsHy9rs1aJOrIUkK+vTWWATq vnc5HZpzhJnbSowfPyLAc75zvFUxDlz+GkGpetgySqxmw1Xk8ky5FJmMO2gLoJmv 0FTxce1uy9cA6sy8wPJ4Y6Xoa5GfC9SL6a5lbIcO8AT4LV7fcc9j9Tde1fSFBt81 sZcqdnslVeZQ5gv/TxMKObuX5FDfIFHkW4OR6azM3aWvZI7UsMSNI72YqDlpg24E XLgbea5MQWG6TTHujgZ3NcKfSpbUj3zRT4j5CZysNQdme5gYCSMZyLn3X10RXhOM vuq7rAK1xXbtFmWW4+jljoDdKiEMiV+aNYXD8Ax2tYqYqEvdGnD4gfjKY4DWp8FD VZ18dXh8hySR1SuManiubzaEfzjHCqNehlpreBUFlsbGWJ7Nk2qs4AiXlFvlG/Ot sjFSTFzmIHU= =0nI+ -----END PGP SIGNATURE----- --=-=-=-- --===============0776097413== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0776097413==--