From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH v2] drm/i915: Fix recursive calls to unmap Date: Sun, 30 Oct 2011 19:35:11 -0700 Message-ID: References: <1320024054-4732-1-git-send-email-ben@bwidawsk.net> <20111030185210.6d3a74d4@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1945402700==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 522B19E8BC for ; Sun, 30 Oct 2011 19:35:15 -0700 (PDT) In-Reply-To: <20111030185210.6d3a74d4@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1945402700== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 30 Oct 2011 18:52:10 -0700, Ben Widawsky wrote: > Well, I had to pick one, and looking at the call chain, it seemed there w= asn't > much to gain by doing retiring at this point. The point is that you're mixing the stuff the commit message talks about with other changes *which are not mentioned in the commit message* and which are *unrelated to the bug in question*. Two changes get two patches, it's pretty simple. And, commit messages must tell the whole truth and nothing but the truth. I really hate having to be this careful in reviewing your patches. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIUAwUBTq4JXzYtFsjWk68qAQg9Tw/4mV3K2qm7Ani49iATHN9dWsnwSrJefUeg Tt3POFuUs9YI978JTppBgPkHMVJ9MYy3pEtbMXyGnj3ib2+KVMBE+jtYFihTdKuZ Ta/eYawZA12SXc8zUSyLSRcjETt9v8IQ9y5uMGG0eqVZvlMn1f+ihjz1z5+RxXXH 8NvlgVdi47lZrBtoIV9F162VCWADunvfcE6/rqbbd4TjuxJBCXsQoS3tGOXNNaBo kb/HRDmzF0icJocpd/I/bWlEYXTsLwqyV9WDVgM2V7f7/SmOe4wsXbsA7/60xyBq LvxOtDmzwwpnHqD/BF1hZSaB45KiATTorQrp0GtO2AWF480UQnTda2AHE0FV+kV6 YFgqH/GQw3/LYF61/LCxk6NUNIh5FWn86QgN61k9i7ShNzwO9k+yLxohRD5B4UVM Tx/UdN7hfA9hvzPZL0GFmh+1cSvDgkVl7zYHg06L6ebfK1hFopXCjNr19kLCN5XS FSz+SaXwsdullyD+0TefWf9wpUexCqRNgi0cKh1s5afopoSEygP5+8oxHz00DenC G3L0gdbuchcW+/1oImxkrOd6fxwYQFQISJl4SBBxc4XOhpyuERQrvLz9PCevzJKJ Vy1Kngwlf994ciE0OftmwYDZA57IYlEUeVUJEZcBQoq4VdLFj4TQtDwA07Gfb4fl KNEMJH148A== =oDTQ -----END PGP SIGNATURE----- --=-=-=-- --===============1945402700== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1945402700==--