All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: "Feng, Boqun" <boqun.feng@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH] drm/i915: fix user irq miss in BSD ring on g4x
Date: Mon, 16 May 2011 00:07:03 -0700	[thread overview]
Message-ID: <yunboz32kfc.fsf@aiko.keithp.com> (raw)
In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F224C32865A@shsmsx501.ccr.corp.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 487 bytes --]

On Mon, 16 May 2011 12:43:23 +0800, "Feng, Boqun" <boqun.feng@intel.com> wrote:

> That's why I want to open-code ring_get_irq.

Right, I read through the code again and found that you're just
mirroring the structure of code for the other two rings, neither of
which shared the ring_get_irq/ring_put_irq functions anyways.

Thanks for the explanation; please update the commit message to include
enough of this information to make it clear too.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-05-16  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03  4:42 [PATCH] drm/i915: fix user irq miss in BSD ring on g4x Feng, Boqun
2011-05-13 15:07 ` Keith Packard
2011-05-16  4:43   ` Feng, Boqun
2011-05-16  7:07     ` Keith Packard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-16  8:02 Feng, Boqun
2011-05-16 10:27 ` Konstantin Belousov
2011-05-16 19:53   ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunboz32kfc.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=boqun.feng@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.