From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: fix user irq miss in BSD ring on g4x Date: Mon, 16 May 2011 00:07:03 -0700 Message-ID: References: <1304397744-29312-1-git-send-email-boqun.feng@intel.com> <749B9D3DBF0F054390025D9EAFF47F224C32865A@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1873910564==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id C9E479E761 for ; Mon, 16 May 2011 00:07:17 -0700 (PDT) In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F224C32865A@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Feng, Boqun" , "intel-gfx@lists.freedesktop.org" Cc: "stable@kernel.org" List-Id: intel-gfx@lists.freedesktop.org --===============1873910564== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 16 May 2011 12:43:23 +0800, "Feng, Boqun" wr= ote: > That's why I want to open-code ring_get_irq. Right, I read through the code again and found that you're just mirroring the structure of code for the other two rings, neither of which shared the ring_get_irq/ring_put_irq functions anyways. Thanks for the explanation; please update the commit message to include enough of this information to make it clear too. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFN0M0XQp8BWwlsTdMRAjbwAKDrFDmDJksYMdnzD4nq8wN66yDTXACghQPr Qvfe/TowjRcLLFIEM+UbBCQ= =NLxD -----END PGP SIGNATURE----- --=-=-=-- --===============1873910564== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1873910564==--