From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: Enable SDVO hotplug interrupts
	for HDMI and DVI
Date: Tue, 20 Sep 2011 09:55:08 -0700
Message-ID: <yund3evf91v.fsf@aiko.keithp.com>
References: <1316528258-23006-1-git-send-email-simon.farnsworth@onelan.co.uk>
	<yunlitjfabh.fsf@aiko.keithp.com>
	<201109201738.37448.simon.farnsworth@onelan.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1166067238=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 63E0F9E94A
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 20 Sep 2011 09:55:13 -0700 (PDT)
In-Reply-To: <201109201738.37448.simon.farnsworth@onelan.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1166067238==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 20 Sep 2011 17:38:37 +0100, Simon Farnsworth <simon.farnsworth@onel=
an.co.uk> wrote:

> This interacts badly with the need I've found to call this function every=
 time=20
> a hotplug interrupt comes through (explained below) - I'm not sure how to=
=20
> track back from the encoder (which gets the callback) to the SDVO device=
=20
> number.

You might store the desired hotplug bits in the intel_sdvo structure,
and then use that in the enable function. The enable function should be
able to just call SET_ACTIVE_HOT_PLUG with the desired value instead of
making the four calls that it does now, right?

> If I don't call intel_sdvo_enable_hotplug at this point, I only get the o=
ne=20
> hotplug interrupt; it appears that the SDVO devices I have send their=20
> interrupt, then expect you to re-enable HPD interrupts before they will s=
end=20
> another interrupt.

ok, sounds good.

> I'm not sure how best to handle this; my gut feeling is that there's no r=
eal=20
> harm enabling HPD interrupts on all ports that support it, even though I'=
m=20
> only processing HPD interrupts from DVI and HDMI ports. If you have bette=
r=20
> ideas, I'm happy to try them.

It probably is harmless, just seems a bit messy.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOeMVtQp8BWwlsTdMRAsC3AJ4pfsFeicEPAAoxkpTe9hMp6VIUtACdEgYn
MYBIimFYNrV6Io6Nqp6yEeI=
=lFch
-----END PGP SIGNATURE-----
--=-=-=--

--===============1166067238==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1166067238==--