From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
dri-devel@lists.freedesktop.org,
xorg-devel@lists.freedesktop.org
Subject: Re: [PATCH] Pack swap complete bits into an XEvent
Date: Thu, 28 Apr 2011 15:01:16 -0700 [thread overview]
Message-ID: <yund3k63uj7.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1304022442-8070-2-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 832 bytes --]
On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The defintion of the swap complete event was wrong; XEvents are only 32
> bytes long, and with padding the swap event was longer. So use some
> creative packing to get all the bits we want transmitted. Requires a
> proto version bump.
If you've got a proto version on both sides, you should just stick the
low 32 bits in place of the event type and pad fields, rather than
abusing. Yes, this requires two different structures in the X server,
but you need to do that anyways -- the event type has to shrink from 16
bits to 8 bits, moving it at the same time is not a problem.
Besides, this will make the xcb case really ugly as xcb doesn't hide the
protocol event structures from the application.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-04-28 22:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 20:27 [RFC] swap event handling fixes Jesse Barnes
2011-04-28 20:27 ` [PATCH] Pack swap complete bits into an XEvent Jesse Barnes
2011-04-28 21:33 ` Eric Anholt
[not found] ` <87y62uhxh5.fsf-NuZ+OHacjZctnJUoGz2Qal6hYfS7NtTn@public.gmane.org>
2011-04-28 21:34 ` Jesse Barnes
2011-04-28 22:01 ` Keith Packard [this message]
[not found] ` <1304022442-8070-1-git-send-email-jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2011-04-28 20:27 ` [PATCH] Fix swap complete event size Jesse Barnes
2011-04-29 21:37 ` [RFC] swap event handling fixes Jesse Barnes
2011-04-29 23:10 ` Mario Kleiner
2011-05-02 20:09 ` Jesse Barnes
2011-04-28 20:27 ` [PATCH] GLX/DRI2: fix swap complete handling Jesse Barnes
2011-04-28 20:27 ` [PATCH] DRI2/GLX: fix swap event handling Jesse Barnes
[not found] ` <1304022442-8070-5-git-send-email-jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2011-04-28 21:37 ` Eric Anholt
2011-04-29 6:52 ` Michel Dänzer
2011-04-29 7:20 ` Julien Cristau
2011-04-29 15:24 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yund3k63uj7.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=xorg-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.