From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/6] drm/i915: Pass the saved adjusted_mode when adding to the load-detect crtc
Date: Wed, 20 Apr 2011 14:00:42 -0700 [thread overview]
Message-ID: <yund3kghc3p.fsf@aiko.keithp.com> (raw)
In-Reply-To: <0d30dc$lu2ikk@orsmga001.jf.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
On Wed, 20 Apr 2011 20:38:54 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, 20 Apr 2011 11:23:01 -0700, Keith Packard <keithp@keithp.com> wrote:
> > On Wed, 20 Apr 2011 10:22:20 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Reviewed-by: Keith Packard <keithp@keithp.com>
> >
> > (this might be separately tested to see if it might fix some TV load
> > detection issues?)
>
> It is an old bug along a dead code path. It can simply be squashed with
> the next patch that removes it entirely, if you prefer.
Right, I didn't look forward to see that it was in 're-use existing
pipe' path which has been dead for a long time now.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-04-20 21:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 9:22 Remove dead code from intel_get_load_detect_pipe Chris Wilson
2011-04-20 9:22 ` [PATCH 1/6] drm/i915: Simplify return value " Chris Wilson
2011-04-20 18:10 ` Keith Packard
2011-04-20 18:26 ` [PATCH 1/2] " Chris Wilson
2011-04-20 18:26 ` [PATCH 2/2] drm/i915: Propagate failure to set mode for load-detect pipe Chris Wilson
2011-04-20 9:22 ` [PATCH 2/6] drm/i915: Don't store temporary load-detect variables in the generic encoder Chris Wilson
2011-04-20 18:12 ` Keith Packard
2011-04-20 9:22 ` [PATCH 3/6] drm/i915: Remove unused supported_crtc from intel_load_detect_pipe Chris Wilson
2011-04-20 18:12 ` Keith Packard
2011-04-20 9:22 ` [PATCH 4/6] drm/i915: Pass the saved adjusted_mode when adding to the load-detect crtc Chris Wilson
2011-04-20 18:23 ` Keith Packard
2011-04-20 19:38 ` Chris Wilson
2011-04-20 21:00 ` Keith Packard [this message]
2011-04-20 9:22 ` [PATCH 5/6] drm/i915: Remove dead code from intel_get_load_detect_pipe() Chris Wilson
2011-04-20 18:26 ` Keith Packard
2011-04-20 9:22 ` [PATCH 6/6] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-20 18:43 ` Keith Packard
2011-04-20 18:55 ` Chris Wilson
2011-04-20 21:03 ` Keith Packard
2011-04-20 21:43 ` [PATCH] " Chris Wilson
2011-04-21 8:45 ` When in doubt, use a temporary fb Chris Wilson
2011-04-21 8:45 ` [PATCH 1/3] drm/i915: Remove dead code from intel_release_load_detect_pipe() Chris Wilson
2011-04-21 8:45 ` [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-21 8:45 ` [PATCH 3/3] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable Chris Wilson
2011-04-20 20:16 ` [PATCH] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yund3kghc3p.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.