From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Date: Wed, 21 Sep 2011 08:47:50 -0700 Message-ID: References: <1316539885-3196-1-git-send-email-simon.farnsworth@onelan.co.uk> <201109211008.14518.simon.farnsworth@onelan.co.uk> <201109211618.55592.simon.farnsworth@onelan.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0811232750==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id C68E29E77F for ; Wed, 21 Sep 2011 08:47:53 -0700 (PDT) In-Reply-To: <201109211618.55592.simon.farnsworth@onelan.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0811232750== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 21 Sep 2011 16:18:55 +0100, Simon Farnsworth wrote: > I'm ANDing the value returned by hardware with 3 - I should be ANDing it = with=20 > an appropriate ~3. The rest of the code (setting those bits in=20 > intel_sdvo_dvi_init based on what functions I have) should be OK. Oh, that's a good point. I'd say that you shouldn't change any bits you don't know about. So, fetch the current active hotplug value and then clear bits 0 and 1 so that we change only those. > I would still like someone with the spec to go over what I'm doing - this= =20 > seems appropriate, but *all* I have to test against are two different=20 > motherboards with "integrated" DVI-D that turns out to be an SDVO > device. Yeah, I've been digging around for an SDVO spec, but it's buried as it contains a pile of stuff for macro-vision and other content protection bits. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOegcmQp8BWwlsTdMRAjgMAJ9PSOJYT1c5oCQeTLC+oGkELXwrRwCgxLDI Nls2O/XrEePOVvFpfm7n4cM= =Y3uV -----END PGP SIGNATURE----- --=-=-=-- --===============0811232750== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0811232750==--