From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: Skip GPU wait for scanout pin
	while wedged
Date: Tue, 19 Jul 2011 17:22:49 -0700
Message-ID: <yunei1lol5y.fsf@aiko.keithp.com>
References: <1311118003-3443-1-git-send-email-keithp@keithp.com>
	<aefc95$s7qt6@orsmga001.jf.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2137149032=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 36A339E9BF
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 19 Jul 2011 17:22:56 -0700 (PDT)
In-Reply-To: <aefc95$s7qt6@orsmga001.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============2137149032==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 20 Jul 2011 01:03:17 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:

> This doesn't prevent us returning an error should the wait-rendering abort
> due to a GPU hang occurring in the middle of the wait.

Yeah, should probably check the return value and ignore the error instead.

> i915_gem_object_pin_to_display_plane is used for more than just the
> scanout, cursors and overlay are also included, otherwise we could just
> ignore any errors. So,

Given that the GPU is wedged, I don't see any problem pinning any of
these instead of failing.

> /* Update the display engine regardless of any GPU hangs */
> if (ret =3D=3D -ERESTARTSYS)
> 	return ret;

Yeah, that seems simpler in all ways. Much nicer.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOJh/ZQp8BWwlsTdMRAieaAKCTYv0rlU7e26jx35wPgQ7W3fzTOwCeNMtw
fo/dktyh+Djwmi56K4L7M1w=
=ibR7
-----END PGP SIGNATURE-----
--=-=-=--

--===============2137149032==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============2137149032==--