From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Mihai Moldovan <ionic@ionic.de>
Cc: linux-kernel@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915/sdvo: Reorder i2c initialisation before ddc proxy
Date: Tue, 17 May 2011 18:22:52 -0700 [thread overview]
Message-ID: <yunei3wssyb.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1305637430-16026-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Tue, 17 May 2011 14:03:50 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The ddc proxy depends upon the underlying i2c bus being selected. Under
> certain configurations, the i2c-adapter functionality is queried during
> initialisation and so may trigger an OOPS during boot. Hence, we need to
> reorder the initialisation of the ddc proxy until after we hook up the i2c
> adapter for the SDVO device.
I'd love more explanation here about how this code ever worked -- what
are these 'certain configurations' of which you speak?
(on the surface, this patch seems sane, but I'd love to review with
specific knowledge about what configurations would have worked and which
would have triggered this bug).
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-05-18 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:05 Kernel BUG with i915 in intel_sdvo_ddc_proxy_func Mihai Moldovan
2011-05-17 12:37 ` Mihai Moldovan
2011-05-17 13:03 ` [PATCH] drm/i915/sdvo: Reorder i2c initialisation before ddc proxy Chris Wilson
2011-05-17 13:49 ` Mihai Moldovan
2011-05-18 1:22 ` Keith Packard [this message]
2011-05-18 8:04 ` Chris Wilson
2011-05-18 14:40 ` Keith Packard
2011-05-18 16:08 ` Mihai Moldovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunei3wssyb.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=ionic@ionic.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.