From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: fix user irq miss in BSD ring on g4x Date: Fri, 13 May 2011 08:07:57 -0700 Message-ID: References: <1304397744-29312-1-git-send-email-boqun.feng@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0528956791==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id D61189E74C for ; Fri, 13 May 2011 08:08:00 -0700 (PDT) In-Reply-To: <1304397744-29312-1-git-send-email-boqun.feng@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Feng, Boqun" , intel-gfx@lists.freedesktop.org Cc: stable@kernel.org List-Id: intel-gfx@lists.freedesktop.org --===============0528956791== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 3 May 2011 12:42:24 +0800, "Feng, Boqun" wr= ote: > On g4x, user interrupt in BSD ring is missed. > g4x and ironlake share the same bsd_ring, but their interrupt control > interfaces are different. On g4x i915_enable_irq and i915_disable_irq > are used to enable/disable irq,and user interrupt flag in BSD ring on > g4x is I915_BSD_USER_INTERRUPT. > The ring_get_irq and ring_put_irq use ironlake style interrupt control > interface. So rather than use them, expand their code and add an if-else > statement about the device version. Please don't open-code ring_get_irq here. I'd suggest a cleaner fix would be to either just conditionally call ring_get_irq, or to stick the BSD interrupt value in dev_priv where you can get it: if (IS_G4X(dev)) ring_get_irq(ring, I915_BSD_USER_INTERRUPT); else ring_get_irq(ring, GT_BSD_USER_INTERRUPT); or ring_get_irq(ring, dev_priv->bsd_user_interrupt); =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNzUlNQp8BWwlsTdMRAgwnAKCFBE71MV6ApjA6FuPSH2JzpItE3ACfWunI /lgFxAruVeNkne7OinQVMro= =rngx -----END PGP SIGNATURE----- --=-=-=-- --===============0528956791== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0528956791==--