From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 08/19] drm/i915: manual FDI training for Ivy
	Bridge
Date: Thu, 28 Apr 2011 15:43:10 -0700
Message-ID: <yunei4m2e0x.fsf@aiko.keithp.com>
References: <1304028785-10583-1-git-send-email-jbarnes@virtuousgeek.org>
	<1304028785-10583-9-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0908001769=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 618F79EA00
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 28 Apr 2011 15:43:29 -0700 (PDT)
In-Reply-To: <1304028785-10583-9-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0908001769==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 28 Apr 2011 15:12:54 -0700, Jesse Barnes <jbarnes@virtuousgeek.org>=
 wrote:

> +	if (IS_GEN6(dev)) {
> +		temp &=3D ~FDI_LINK_TRAIN_NONE;
> +		temp |=3D FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE;
> +	} else if (IS_IVYBRIDGE(dev)) {
> +		temp &=3D ~FDI_LINK_TRAIN_NONE_IVB;
> +		temp |=3D FDI_LINK_TRAIN_NONE_IVB | FDI_TX_ENHANCE_FRAME_ENABLE;
> +	}

This seems inconsistent using IS_GEN6 for SNB and IS_IVYBRIDGE for IVB?

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFNue1+Qp8BWwlsTdMRAl2HAJ0QH9VpI2832rT8WolhxoQup8OLVwCg2ftA
YvL/aDBKB12Eag/wolV2Tvk=
=4HfK
-----END PGP SIGNATURE-----
--=-=-=--

--===============0908001769==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0908001769==--