From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: fix intel_crtc_get_clock pipe
	reads after "cleanup"
Date: Fri, 22 Apr 2011 16:08:42 -0700
Message-ID: <yunfwp9hojp.fsf@aiko.keithp.com>
References: <1303507348-11460-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0817394500=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 18F0A9E793
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 22 Apr 2011 16:08:50 -0700 (PDT)
In-Reply-To: <1303507348-11460-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@kernel.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0817394500==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 22 Apr 2011 22:22:28 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:

>  		fp =3D FP0(pipe);
>  	else
>  		fp =3D FP1(pipe);
> +	fp =3D I915_READ(fp);

Please use different variables for the offset vs the value...

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFNsgp6Qp8BWwlsTdMRAj8MAJ9d0od3R9M5QlQOHssh2ZyCTTD3BgCfRyXk
wagDYdk1ThTuKjHRVdAfKZQ=
=mifR
-----END PGP SIGNATURE-----
--=-=-=--

--===============0817394500==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0817394500==--