From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: Ironlake GPU with VT-d fix Date: Thu, 22 Sep 2011 21:50:49 -0700 Message-ID: References: <1316736712-5887-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0683590318==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 58D4D9EB6F for ; Thu, 22 Sep 2011 21:50:54 -0700 (PDT) In-Reply-To: <1316736712-5887-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Dave Airlie , Ben Widawsky , David Woodhouse List-Id: intel-gfx@lists.freedesktop.org --===============0683590318== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 22 Sep 2011 17:11:52 -0700, Ben Widawsky wrote: > It requires an additional IOMMU patch. Can we collect those two patches into one sequence? > + if ((gpu_devid =3D=3D PCI_DEVICE_ID_INTEL_IRONLAKE_M_HB || > + gpu_devid =3D=3D PCI_DEVICE_ID_INTEL_IRONLAKE_M_IG) && > + intel_private.base.needs_dmar) > + intel_private.base.do_idle_maps =3D 1; > + I'd like to make this conditional on whether IOMMU is actually in use; needs_dmar is based solely on whether the DMA_API is compiled into the kernel and the GTT gen is > 2. > - if (lists_empty) > + if (lists_empty && !!dev_priv->mm.gtt->do_idle_maps) > return 0; Is it necessary to change the semantic of this function in cases which aren't related to GTT remapping? Seems like you're imposing a fairly high cost on operations which don't actually need it. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOfBApQp8BWwlsTdMRAijIAKCJBAIKkmwMb2uDxPC2870mp/yM+QCfUhO4 raXPuC4H1RvtdNvRLo87t1g= =jxei -----END PGP SIGNATURE----- --=-=-=-- --===============0683590318== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0683590318==--