From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 14/16] drm/i915: Use PCI-ID to identify Broadwater and Crestline Date: Sun, 15 May 2011 15:01:15 -0700 Message-ID: References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-15-git-send-email-chris@chris-wilson.co.uk> <20110515204901.GC3510@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1456611905==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FE289E7BA for ; Sun, 15 May 2011 15:01:19 -0700 (PDT) In-Reply-To: <20110515204901.GC3510@viiv.ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1456611905== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 15 May 2011 22:49:02 +0200, Daniel Vetter wrote: > I actually like this: I saves one needless indirection when reading > codepaths and trying to find out what code is run for a given pci id. > Also, these two bits seem to be the only ones that are used in only _one_ > device type, which is a bit confusing. Yeah, we've got a bunch of single-bits per display generation; should we create one of those for broadwater+crestline? That combination is used a couple of times in the driver. Thanks for your comments; I'll take this patch and we can consider whether to add a bit for crestline+broadwater later. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFN0E0rQp8BWwlsTdMRAs9pAJ9YJ+TantYL2uw79WWWCsVeh0j74gCgzz38 0Ip/CBpkdRXOmbdnTBnOTPM= =0LNP -----END PGP SIGNATURE----- --=-=-=-- --===============1456611905== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1456611905==--