From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: force wake reference counting (another try) Date: Tue, 12 Apr 2011 10:41:47 -0700 Message-ID: References: <1302570079-17032-1-git-send-email-ben@bwidawsk.net> <1bdc18$k6h5tu@fmsmga002.fm.intel.com> <20110412163022.GA12791@snipes.kumite> <1bdc18$k6n2j0@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1455669778==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 83B039EF7B for ; Tue, 12 Apr 2011 10:41:51 -0700 (PDT) In-Reply-To: <1bdc18$k6n2j0@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1455669778== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 12 Apr 2011 18:21:23 +0100, Chris Wilson = wrote: > Agreed. I had been working under the assumption that dev->struct_mutex was > the sufficient lock. This may be entirely due to the false premise that we > only needed i915_gt_read() for the ring registers. I still haven't looked > through just what registers are impacted. Seems like we should start using a spinlock and wake lock around all register accesses, then figure out which registers are not within the GT power well and split those off to a separate macro which avoids both. If we finally discover that all wake-lock requiring registers are now obviously covered by the struct mutex, we could then consider removing the spinlock. Make it work, then make it fast. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNpI7bQp8BWwlsTdMRAp5kAJ9QQX4QI+0JMCNkkBs6cY+6GAlk9QCePVc5 CQ8CMGr4jaETWZBgviEP7fs= =iZZ7 -----END PGP SIGNATURE----- --=-=-=-- --===============1455669778== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1455669778==--