From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH fixes] drm/i915: Fix unfenced alignment on
	pre-G33 hardware
Date: Mon, 06 Jun 2011 09:03:30 -0700
Message-ID: <yunlixf0wx9.fsf@aiko.keithp.com>
References: <1307369924-3601-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1191138332=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7E7CE9E768
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  6 Jun 2011 09:25:12 -0700 (PDT)
In-Reply-To: <1307369924-3601-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@kernel.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1191138332==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon,  6 Jun 2011 15:18:44 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:

>  	case I915_PARAM_HAS_RELAXED_FENCING:
> -		value =3D 1;
> +		value =3D 2;

This looks like a change in ABI to me. I think this means you want a new
ioctl so that applications using the existing HAS_RELAXED_FENCING ioctl
and expecting a boolean will continue to work.

>  uint32_t
> -i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj);
> +i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj,
> +				    int tiling_mode);
...
> -				i915_gem_get_unfenced_gtt_alignment(obj);
> +				i915_gem_get_unfenced_gtt_alignment(obj,
> +								    args->tiling_mode);

This combination looks like a simple bug fix -- not using the new tiling
mode when computing the required alignment. Can you separate out this
From=20the power-of-two change?

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFN7PpTQp8BWwlsTdMRAkN7AKCPcgSAXoQWKPB7L7l+RPJ7Q9e/6wCZAYTg
ZD5/bKGLmfJ4xgjUzarOef8=
=g79l
-----END PGP SIGNATURE-----
--=-=-=--

--===============1191138332==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1191138332==--