From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 08/16] drm/i915/i2c: Convert from using
	GMBUS1 + reg_offset idiom to reg + 0
Date: Fri, 13 May 2011 08:00:40 -0700
Message-ID: <yunliya7ihz.fsf@aiko.keithp.com>
References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk>
	<1305235044-9159-9-git-send-email-chris@chris-wilson.co.uk>
	<yunfwoj8mb9.fsf@aiko.keithp.com>
	<72a37e$j4eltu@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0808860654=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id CB09E9EB70
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 13 May 2011 08:00:44 -0700 (PDT)
In-Reply-To: <72a37e$j4eltu@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0808860654==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 13 May 2011 10:28:34 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:

> And how about something like:
>=20
> #define I915_GMBUS_WRITE(reg, val) \
>    I915_WRITE(intel_gmbus_reg(dev_priv->dev, reg), val)
>=20
> I915_GMBUS_WRITE(0, val);

Yes, that's very pretty! And do give it a try this time :-)

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFNzUeYQp8BWwlsTdMRAkZ7AKCmUelxNGe2qE0X0ZUcFbMBZAizdwCbBC8M
CDWvFarHeh/TpZVekbgVmgs=
=IrSH
-----END PGP SIGNATURE-----
--=-=-=--

--===============0808860654==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0808860654==--