From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Date: Wed, 21 Sep 2011 07:58:51 -0700 Message-ID: References: <1316539885-3196-1-git-send-email-simon.farnsworth@onelan.co.uk> <201109211008.14518.simon.farnsworth@onelan.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0229265819==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BF379E74F for ; Wed, 21 Sep 2011 07:58:58 -0700 (PDT) In-Reply-To: <201109211008.14518.simon.farnsworth@onelan.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0229265819== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 21 Sep 2011 10:08:13 +0100, Simon Farnsworth wrote: > I'm clearing the bits (&=3D not |=3D). I could respin setting it to 0, bu= t that=20 > takes me even further from the old (commented out) code, and I'd really w= ant=20 > someone to check SDVO specs before doing that. What I see the code doing is asking whether devices 0 and 1 *could* support hotplug and then unconditionally setting the devices for which we *want* hotplug to that. I think you should set the list of devices requesting hotplug to be the intersection of the set of devices which *could* do hotplug and the set of devices for which we *want* hotplug. That seems like it would be achieved by just clearing the set of devices that we will request hotplug for and then checking which ones are supported and incrementally adding those to the hotplug_active set. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOefurQp8BWwlsTdMRAnO3AKCLVFi6re4xZpqHbnZm9DM5+d2uNwCfTdDY P61pwGQC9ZcOKPfn5n22ofA= =xKS8 -----END PGP SIGNATURE----- --=-=-=-- --===============0229265819== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0229265819==--