From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915/pch: Fix integer math bugs in
	panel fitting
Date: Wed, 13 Jul 2011 13:47:40 -0700
Message-ID: <yunoc0x9ac3.fsf@aiko.keithp.com>
References: <1310589152-31945-1-git-send-email-ajax@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1996630710=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2846A9E89D
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 13 Jul 2011 13:47:46 -0700 (PDT)
In-Reply-To: <1310589152-31945-1-git-send-email-ajax@redhat.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Adam Jackson <ajax@redhat.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1996630710==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 13 Jul 2011 16:32:32 -0400, Adam Jackson <ajax@redhat.com> wrote:

> +				if (width & 1)
> +				    	width++;


> +				if (height & 1)
> +				    height++;

You'll want to stick a comment in here describing why this is
here. Otherwise, someone will just break it in the future.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOHgRsQp8BWwlsTdMRAmFyAKDo7gmKQEl+K2UAVSwpOMeqhbheVgCgxVEw
GRh0iemDhPkwdzeJomV7OaI=
=WDDU
-----END PGP SIGNATURE-----
--=-=-=--

--===============1996630710==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1996630710==--