From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 06/16] drm/i915: Replace ironlake_compute_wm0 with g4x_compute_wm0 Date: Fri, 13 May 2011 08:00:01 -0700 Message-ID: References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-7-git-send-email-chris@chris-wilson.co.uk> <382e69$cvag6s@azsmga001.ch.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1849283195==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id D33AF9E74C for ; Fri, 13 May 2011 08:00:04 -0700 (PDT) In-Reply-To: <382e69$cvag6s@azsmga001.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1849283195== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 13 May 2011 10:19:52 +0100, Chris Wilson = wrote: > On Thu, 12 May 2011 17:34:49 -0700, Keith Packard wro= te: > > On Thu, 12 May 2011 22:17:14 +0100, Chris Wilson wrote: > > > The computation of the first-level watermarks for g4x and gen5+ are > > > based on the same algorithm, so we can refactor those code paths to > > > use a single function. > >=20 > > g4x_compute_wm0 takes a plane. ironlake_compute_wm0 takes a pipe. The > > change implicitly assumes that pipe =3D=3D plane on ironlake. Please cl= arify? >=20 > We lucked out. It should have been a plane on Ironlake as well. > Fortunately on ILK+ each pipe is slaved to one (identically numbered) > plane. Heh. Please make sure you mention stuff like that in commit messages when you find them. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNzUdxQp8BWwlsTdMRAo4KAJ9qF2pJ08eDBhGAB9Df+vOdAUJrtwCfVmNp 6bXJ+XlHJ7Du/hcmclwghno= =xupG -----END PGP SIGNATURE----- --=-=-=-- --===============1849283195== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1849283195==--