From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915/overlay: Fix unpinning along init error paths Date: Tue, 28 Jun 2011 09:08:32 -0700 Message-ID: References: <1309256867-26210-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0909769400==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 9792B9E880 for ; Tue, 28 Jun 2011 09:08:36 -0700 (PDT) In-Reply-To: <1309256867-26210-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0909769400== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 28 Jun 2011 11:27:47 +0100, Chris Wilson = wrote: > As pointed out by Dan Carpenter, it was seemingly possible to hit an error > whilst mapping the buffer for the regs (except the only likely error > returns should not happen during init) and so leak a pin count on the > bo. To handle this we would need to reacquire the struct mutex, so for > simplicity rearrange for the lock to be held for the entire function. > For extra pedagogy, test that we only call init once. >=20 > Signed-off-by: Chris Wilson Reviewed-by: Keith Packard I'll get this into drm-intel-fixes once I can fast forward and pick up Hugh's original patch. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOCfyBQp8BWwlsTdMRAh7LAKDHuaRgn+R6spYb7BJBZ8h0c1pg/ACfa67l +MKaFTApdm6xV/Kqfe0CYiA= =vQRo -----END PGP SIGNATURE----- --=-=-=-- --===============0909769400== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0909769400==--