All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Wang, Zhenyu Z" <zhenyu.z.wang@intel.com>,
	"intel-gfx@lists.freedesktop..."
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	Christopher White <c.white@pulseforce.com>,
	Jeremy Bush <contractfrombelow@gmail.com>,
	"Bossart, Pierre-louis" <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH v3] pass ELD to HDMI/DP audio driver
Date: Thu, 04 Aug 2011 11:03:41 -0700	[thread overview]
Message-ID: <yunsjph835u.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20110804094024.GB21137@localhost>


[-- Attachment #1.1: Type: text/plain, Size: 1088 bytes --]

On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:

> Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(),  
> the drm_encoder object is there, however encoder->crtc is NULL at the
> time.

Correct. encoder->crtc is set only when the output is active.

> You may wonder why the mode parameter is needed in intel_write_eld().
> This is because the ELD field aud_synch_delay (ie. A/V sync delay) may
> have different values in progressive/interleaved display modes.

Ok, so you can't write ELD data until the display is active, which
happens at mode_set time.

Do you need to provide ELD when the display is inactive? Is this only to
enable audio output when the display is not on? In that case, we will
need to essentially turn enough of the output on to allow for audio
data, picking a mode which provide sufficient bandwidth.

> I tested Ivybridge yesterday and ironlake_write_eld seems to not work
> properly for Ivybridge. Need to double check its spec.

That's unfortunate...

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2011-08-04 18:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  6:20 [PATCH] pass ELD to HDMI/DP audio driver Wu Fengguang
2011-06-29  6:36 ` Wu Fengguang
2011-06-29  7:00 ` Takashi Iwai
2011-06-29 13:10 ` [PATCH v2] " Wu Fengguang
2011-06-29 23:11   ` Ben Skeggs
2011-07-29 20:07   ` Jesse Barnes
2011-08-01 13:51     ` [PATCH v3] " Wu Fengguang
2011-08-04  2:48       ` Keith Packard
2011-08-04  9:40         ` Wu Fengguang
2011-08-04 18:03           ` Keith Packard [this message]
2011-08-05 12:49             ` Wu Fengguang
2011-08-05 15:52               ` Stephen Warren
2011-08-06 20:02               ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunsjph835u.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bskeggs@redhat.com \
    --cc=c.white@pulseforce.com \
    --cc=contractfrombelow@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=pierre-louis.bossart@intel.com \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.