From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: apply phase pointer override on
	SNB+ too
Date: Fri, 29 Jul 2011 11:47:55 -0700
Message-ID: <yuntya4hqjo.fsf@aiko.keithp.com>
References: <1311961811-1813-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1760971782=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 366DBA09BA
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Jul 2011 11:47:59 -0700 (PDT)
In-Reply-To: <1311961811-1813-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1760971782==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 29 Jul 2011 10:50:11 -0700, Jesse Barnes <jbarnes@virtuousgeek.org>=
 wrote:

> +	flags |=3D FDI_PHASE_SYNC_OVR(pipe);
> +	I915_WRITE(SOUTH_CHICKEN1, flags); /* once to unlock... */
> +	flags |=3D FDI_PHASE_SYNC_EN(pipe);
> +	I915_WRITE(SOUTH_CHICKEN1, flags); /* then again to enable */
> +	POSTING_READ(SOUTH_CHICKEN1);
> +}

ooh, this even makes the sequence of two writes sound sensible.

Reviewed-by: Keith Packard <keithp@keithp.com>

You didn't happen to check the register values after doing this, did
you? Just to verify that all of the crazy math works, given that we
can't actually test whether this fixes anything.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOMwBbQp8BWwlsTdMRAt4dAJ97rSGrKKecoXsRMADLbChzHqgPHQCfYBg7
xf/jZRbcJwCiBOwNB/G2e6A=
=U3oy
-----END PGP SIGNATURE-----
--=-=-=--

--===============1760971782==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1760971782==--