From: Keith Packard <keithp@keithp.com>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge.
Date: Tue, 07 Jun 2011 16:14:38 -0700 [thread overview]
Message-ID: <yuntyc1xmht.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1307487281-3015-1-git-send-email-kenneth@whitecape.org>
[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]
On Tue, 7 Jun 2011 15:54:39 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> According to BSpec volume 1c.4 section 3.2.9, Display (Plane) Select is
> now at bits 21:19 instead of 21:20.
>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
I will note that the docs have an obvious bug -- 21:8 are 'reserved' on
IVB while 21:19 are 'Display (Plane) Select'. I trust you've actually
tried this on hardware and noticed that it works better now?
> +
> + case 7:
> + OUT_RING(MI_DISPLAY_FLIP | (intel_crtc->plane << 19));
> + OUT_RING(fb->pitch | obj->tiling_mode);
> + OUT_RING(obj->gtt_offset);
> +
> + pf = I915_READ(PF_CTL(pipe)) & PF_ENABLE;
> + pipesrc = I915_READ(PIPESRC(pipe)) & 0x0fff0fff;
> + OUT_RING(pf | pipesrc);
What's this last DWORD supposed to be for? The IVB spec says length
should be '1' and there should be only 3 DWORDS in this command.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-06-07 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 22:54 [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge Kenneth Graunke
2011-06-07 22:54 ` [PATCH 2/3] drm/i915: Remove HAS_BLT/HAS_BSD checks from ivybridge_irq_postinstall Kenneth Graunke
2011-06-07 23:16 ` Keith Packard
2011-06-08 9:29 ` Chris Wilson
2011-06-07 22:54 ` [PATCH 3/3] drm/i915: Enable GPU reset on Ivybridge Kenneth Graunke
2011-06-07 23:18 ` Keith Packard
2011-06-07 23:14 ` Keith Packard [this message]
2011-06-08 0:55 ` [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset " Kenneth Graunke
2011-06-08 1:09 ` Keith Packard
2011-06-08 9:36 ` Chris Wilson
2011-06-08 9:54 ` Kenneth Graunke
2011-06-08 10:57 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yuntyc1xmht.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.