From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCHv5] drm/i915: Enable SDVO hotplug interrupts
	for HDMI and DVI
Date: Tue, 20 Sep 2011 12:43:31 -0700
Message-ID: <yunvcsndmos.fsf@aiko.keithp.com>
References: <1316539885-3196-1-git-send-email-simon.farnsworth@onelan.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1158872777=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 03B9F9E75F
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 20 Sep 2011 12:43:34 -0700 (PDT)
In-Reply-To: <1316539885-3196-1-git-send-email-simon.farnsworth@onelan.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1158872777==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 20 Sep 2011 18:31:25 +0100, Simon Farnsworth <simon.farnsworth@onel=
an.co.uk> wrote:

> +	/* Set up hotplug command - note paranoia about contents of reply.
> +	 * We simply clear out the bits we understand, and hope that
> +	 * the rest are in good shape for the hardware.
> +	 */
> +	intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
> +			     &intel_sdvo->hotplug_active, 2);
> +	intel_sdvo->hotplug_active[0] &=3D 0x3;
> +

This appears to unconditionally set the bits for devices 0 and 1, making
the dvi-specific code that sets the device bit irrelevant. I think you
just want to set hotplug_active to 0.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOeOzjQp8BWwlsTdMRAlIXAJ9NmXm5+fm06Y1BKz/TA13pTmfDgwCfYH5M
+UmLDrD9WeCc6ydX1xUYKPo=
=azJ+
-----END PGP SIGNATURE-----
--=-=-=--

--===============1158872777==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1158872777==--