From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/2] drm/i915: Disable page-faults around the fast pwrite/pread paths Date: Sat, 09 Jul 2011 13:24:02 -0700 Message-ID: References: <1310200731-18086-1-git-send-email-chris@chris-wilson.co.uk> <1310200731-18086-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1462497481==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A6689EF7D for ; Sat, 9 Jul 2011 13:24:12 -0700 (PDT) In-Reply-To: <1310200731-18086-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1462497481== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 9 Jul 2011 09:38:51 +0100, Chris Wilson = wrote: > + /* We have to disable faulting here in case the user address > + * is really a GTT mapping and so we can not enter > + * i915_gem_fault() whilst already holding struct_mutex. > + */ I would (far, far) rather disallow pread through the GTT mapping. There's no credible reason to allow it. Is there some reasonably fast way to detect that these addresses are within the GTT and just bail? Any performance penalty that serves solely to enable abuse of the interface is not reasonable. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOGLjiQp8BWwlsTdMRArlGAKCSgUjETbXKYrUetMa7hTSY2yuAvgCdFbTG 21K1o5s1y9yLb01QaunFufk= =95fy -----END PGP SIGNATURE----- --=-=-=-- --===============1462497481== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1462497481==--